Skip to content

Commit

Permalink
Remove the workaround for match mutating its parameter
Browse files Browse the repository at this point in the history
As the PR fixing the issue has now landed in fastlane 2.205.2

See fastlane/fastlane#20125
  • Loading branch information
AliSoftware committed Apr 21, 2022
1 parent 882a7c0 commit 8855109
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,8 @@ SCREENSHOT_DEVICES = [
'iPad Pro (12.9-inch) (3rd generation)'
].freeze

# rubocop:disable Style/MutableConstant
# Fastlane mutates these internally, see
# https://github.com/fastlane/fastlane/blob/b817148d4967ab6e38b8f1a8b81d1b3e60d6e645/match/lib/match/runner.rb#L84-L86
MAIN_BUNDLE_IDENTIFIERS = %w[com.automattic.woocommerce] # Registered in our main account, for development and AppStore
ALPHA_BUNDLE_IDENTIFIERS = %w[com.automattic.alpha.woocommerce] # Registered in our Enterprise account, for App Center / Installable Builds
# rubocop:enable Style/MutableConstant
MAIN_BUNDLE_IDENTIFIERS = %w[com.automattic.woocommerce].freeze # Registered in our main account, for development and AppStore
ALPHA_BUNDLE_IDENTIFIERS = %w[com.automattic.alpha.woocommerce].freeze # Registered in our Enterprise account, for App Center / Installable Builds

# Use this instead of getting values from ENV directly
# It will throw an error if the requested value is missing
Expand Down

0 comments on commit 8855109

Please sign in to comment.