-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tooling] Update fastlane + remove workaround for match mutation #6689
Conversation
As the PR fixing the issue has now landed in fastlane 2.205.2 See fastlane/fastlane#20125
You can test the changes from this Pull Request by:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
Yes! I've been checking for a Fastlane release daily waiting for your fix to ship. Glad it's finally here.
CircleCI failed with what looks like an error on their end. I restarted it hoping it was just a fluke.
2.3.9 | ||
2.3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick.
I'd be good to only upgrade the expected Bundler version. What do you think?
I've never looked into it, but maybe there's a way to actually lock it. bundle install
warns us if the version is below the required one, but I wonder if we can stop it from even moving on with the process. ...Adding it to the "things I'll look into when I'll have some time" list π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow I'm actually surprised that the downgrade was allowed to happen here, good catch; I'd have expected my run of bundle update fastlane
would have warned me about it at the very least π€ (or maybe it did and I was not attentive enough with the console output?)
I agree about only going up in versions; I'll upgrade my local Bundler version and re-run it to fix that; thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah shoot just realized auto merge already kicked in π
Not sure it's worth doing a PR just for that minor version bump off Bundler in lock file now that this one has already landed then β¦ π€ͺ
What
fastlane
to2.205.2
match
mutating one of its parameter β as my fix for it in Fix crash in match when passing a frozen value as app_identifiersΒ fastlane/fastlane#20125 has finally been released in2.205.2
πTo Test
bundle exec fastlane update_certs_and_profiles
and verify it doesn't crash