Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Update fastlane + remove workaround for match mutation #6689

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

AliSoftware
Copy link
Contributor

What

To Test

  • Run bundle exec fastlane update_certs_and_profiles and verify it doesn't crash

@AliSoftware AliSoftware added this to the 9.1 milestone Apr 21, 2022
@AliSoftware AliSoftware requested review from mokagio and a team April 21, 2022 19:53
@AliSoftware AliSoftware self-assigned this Apr 21, 2022
@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr6689-8855109 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸŽ‰

Yes! I've been checking for a Fastlane release daily waiting for your fix to ship. Glad it's finally here.

CircleCI failed with what looks like an error on their end. I restarted it hoping it was just a fluke.

Comment on lines -372 to +371
2.3.9
2.3.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick.

I'd be good to only upgrade the expected Bundler version. What do you think?

I've never looked into it, but maybe there's a way to actually lock it. bundle install warns us if the version is below the required one, but I wonder if we can stop it from even moving on with the process. ...Adding it to the "things I'll look into when I'll have some time" list πŸ™ƒ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow I'm actually surprised that the downgrade was allowed to happen here, good catch; I'd have expected my run of bundle update fastlane would have warned me about it at the very least πŸ€” (or maybe it did and I was not attentive enough with the console output?)

I agree about only going up in versions; I'll upgrade my local Bundler version and re-run it to fix that; thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah shoot just realized auto merge already kicked in πŸ™ƒ
Not sure it's worth doing a PR just for that minor version bump off Bundler in lock file now that this one has already landed then … πŸ€ͺ

@AliSoftware AliSoftware merged commit 575189e into trunk Apr 22, 2022
@AliSoftware AliSoftware deleted the tooling/update-fastlane-match-fix branch April 22, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants