Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pnpm once again to fix issues with auto-install-peers #35007

Merged
merged 2 commits into from Oct 10, 2022

Conversation

samueljseay
Copy link
Contributor

Changes proposed in this Pull Request:

There were issues with installing dependencies on a monorepo with auto-install-peers enabled. It would crash every time you try and install dependencies and this was causing some serious interruption to dev work.

This fixes that problem by updating the pnpm version constraint (once again) so that users can only use pnpm 7.13.3 and above (where this fix was released: pnpm/pnpm#5467)

How to test the changes in this Pull Request:

  1. CI should pass
  2. Locally you should be able to update your pnpm version npm i -g pnpm and run pnpm i with success. (make sure to clear the pnpm cache just in case: pnpm store prune

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@samueljseay samueljseay requested review from a team and roykho and removed request for a team October 9, 2022 21:57
@github-actions github-actions bot added focus: react admin package: @woocommerce/e2e-environment Issues related to @woocommerce/e2e-environment package. package: @woocommerce/api Issues related to @woocommerce/api package. package: @woocommerce/e2e-core-tests Issues related to @woocommerce/e2e-core-tests package. package: @woocommerce/e2e-utils Issues related to @woocommerce/e2e-utils package. package: @woocommerce/api-core-tests Issues related to @woocommerce/api-core-tests package. package: @woocommerce/admin-e2e-tests issues related to @woocommerce/admin-e2e-tests package: @woocommerce/components issues related to @woocommerce/components package: @woocommerce/csv-export issues related to @woocommerce/csv-export package: @woocommerce/currency issues related to @woocommerce/currency package: @woocommerce/customer-effort-score issues related to @woocommerce/customer-effort-score package: @woocommerce/data issues related to @woocommerce/data package: @woocommerce/date issues related to @woocommerce/date package: @woocommerce/eslint-plugin issues related to @woocommerce/eslint-plugin package: @woocommerce/experimental issues related to @woocommerce/experimental package: @woocommerce/explat issues related to @woocommerce/explat package: @woocommerce/navigation issues related to @woocommerce/navigation package: @woocommerce/number issues related to @woocommerce/number package: @woocommerce/onboarding issues related to @woocommerce/onboarding package: @woocommerce/tracks issues related to @woocommerce/tracks package: dependency-extraction-webpack-plugin issues related to @woocommerce/dependency-extraction-webpack-plugin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Oct 9, 2022
@samueljseay samueljseay requested review from psealock and removed request for roykho October 9, 2022 21:58
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

Test Results Summary

Commit SHA: a3a564c

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests15800201600m 37s
E2E Tests186003018915m 53s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@psealock psealock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well with pnpm v 713.3. Approving while waiting for a fix to come in regarding linting in #35010

@samueljseay samueljseay merged commit aec4421 into trunk Oct 10, 2022
@samueljseay samueljseay deleted the dev/bump-pnpm-version-restraint branch October 10, 2022 03:59
@github-actions github-actions bot added this to the 7.1.0 milestone Oct 10, 2022
@github-actions
Copy link
Contributor

Hi @samueljseay, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: dependency-extraction-webpack-plugin issues related to @woocommerce/dependency-extraction-webpack-plugin package: @woocommerce/admin-e2e-tests issues related to @woocommerce/admin-e2e-tests package: @woocommerce/api Issues related to @woocommerce/api package. package: @woocommerce/api-core-tests Issues related to @woocommerce/api-core-tests package. package: @woocommerce/components issues related to @woocommerce/components package: @woocommerce/csv-export issues related to @woocommerce/csv-export package: @woocommerce/currency issues related to @woocommerce/currency package: @woocommerce/customer-effort-score issues related to @woocommerce/customer-effort-score package: @woocommerce/data issues related to @woocommerce/data package: @woocommerce/date issues related to @woocommerce/date package: @woocommerce/e2e-core-tests Issues related to @woocommerce/e2e-core-tests package. package: @woocommerce/e2e-environment Issues related to @woocommerce/e2e-environment package. package: @woocommerce/e2e-utils Issues related to @woocommerce/e2e-utils package. package: @woocommerce/eslint-plugin issues related to @woocommerce/eslint-plugin package: @woocommerce/experimental issues related to @woocommerce/experimental package: @woocommerce/explat issues related to @woocommerce/explat package: @woocommerce/navigation issues related to @woocommerce/navigation package: @woocommerce/number issues related to @woocommerce/number package: @woocommerce/onboarding issues related to @woocommerce/onboarding package: @woocommerce/tracks issues related to @woocommerce/tracks plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants