Update the monorepo to node v20

[rrennick]

Changes proposed in this Pull Request:

This PR updates node to v20.

Closes #43034 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. This PR was tested by the teams that work in the monorepo with the results being recorded in a discussion

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Bump node version.

Comment

[github-actions]

Hi @jonathansadowski, @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[samueljseay]

Just adding my 2 cents that I've tested blocks workflows with these changes and did not encounter any issues from pnpm install through to running things like pnpm build at root and pnpm watch:build from blocks directory.

[samueljseay]

@rrennick I did notice that it's still fixed to node 16 in this package:

woocommerce/plugins/woocommerce-blocks/bin/eslint-plugin-woocommerce/package.json

Lines 1 to 12 in 8419e0f

	{
	"name": "eslint-plugin-woocommerce",
	"version": "0.0.2",
	"main": "index.js",
	"devDependencies": {
	"eslint": "^8.3.0"
	},
	"engines": {
	"node": "^16.13.0",
	"npm": "^8.0.0"
	}
	}

[rrennick]

I did notice that it's still fixed to node 16 in this package:

@samueljseay Nice catch. I added it to the project workspace in 868fdbf

[samueljseay]

At least from my perspective this looks good. Tested and works well and I've reviewed the code as well.

[jonathansadowski]

Thanks for this change and the coordination here. Blocks E2E tests are failing, but it appears that that might be due to flakiness, and doesn't look related to this change.

[gigitux]

Thanks for working on this! 🙇

Thanks for this change and the coordination here. Blocks E2E tests are failing, but it appears that that might be due to flakiness, and doesn't look related to this change.

I'm not sure about this, but it looks like the upgrade breaks the old infrastructure for the E2E tests. Usually, not all the shards fail at the same time.

While we are currently working on Playwright, some E2E tests run on the old infrastructure.

I will try to figure out if there is a quick fix to restore them or/and consulting with my team mates to ensure to try to migrate the critical tests to the Playwright infrastructure and remove the old one.

[rrennick]

I'm not sure about this, but it looks like the upgrade breaks the old infrastructure for the E2E tests. Usually, not all the shards fail at the same time.

@gigitux I've pushed a change that allows them to run. Some tests were failing locally though.

[gigitux]

I'm not sure about this, but it looks like the upgrade breaks the old infrastructure for the E2E tests. Usually, not all the shards fail at the same time.

@gigitux I've pushed a change that allows them to run. Some tests were failing locally though.

Thanks for the help! I'm investigating this error:

at ClientRequest.<anonymous> (../../node_modules/.pnpm/node-fetch@2.7.0/node_modules/node-fetch/lib/index.js:1501:11)

It looks like there is an issue with node-fetch and the latest versions of node. I'm trying to enforce pnpm to use the last version of node-fetch.

Check this WIP PR: #46460