Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pricing features to General tab #47435

Merged
merged 5 commits into from
May 15, 2024

Conversation

octaedro
Copy link
Contributor

@octaedro octaedro commented May 13, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR moves the pricing features to the General tab.

Screenshot 2024-05-14 at 9 29 42 AM

Closes #47053.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Make sure the New product editor is enabled under /wp-admin/admin.php?page=wc-settings&tab=advanced&section=features.
  2. Go to Products > Add New.
  3. Verify that the Pricing tab is not visible anymore.
  4. Check that the pricing features are now under the General tab.
  5. Create and edit a few products. Everything should work well.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@octaedro octaedro self-assigned this May 13, 2024
@octaedro octaedro added focus: new product ux revamped product management experience team: Mothra labels May 13, 2024
@github-actions github-actions bot added focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 13, 2024
Copy link
Contributor

github-actions bot commented May 13, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@octaedro octaedro requested a review from a team May 14, 2024 12:40
Copy link
Contributor

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@octaedro octaedro marked this pull request as ready for review May 14, 2024 12:40
@octaedro octaedro marked this pull request as draft May 14, 2024 14:43
@octaedro octaedro force-pushed the dev/47053_move_pricing_features_to_general branch from b299a31 to 6515f35 Compare May 14, 2024 14:57
@octaedro octaedro force-pushed the dev/47053_move_pricing_features_to_general branch from 6515f35 to 2a07281 Compare May 14, 2024 18:09
@octaedro octaedro marked this pull request as ready for review May 14, 2024 18:09
Copy link
Contributor

@mdperez86 mdperez86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @octaedro nice job here!

@octaedro octaedro merged commit aa61371 into trunk May 15, 2024
24 checks passed
@octaedro octaedro deleted the dev/47053_move_pricing_features_to_general branch May 15, 2024 17:53
@github-actions github-actions bot added this to the 9.0.0 milestone May 15, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 15, 2024
@rodelgc rodelgc added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests focus: new product ux revamped product management experience needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Mothra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pricing - move pricing features to General
3 participants