Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for logged in user on the order received page for displaying billing/shipping addresses #47477

Conversation

wavvves
Copy link
Contributor

@wavvves wavvves commented May 14, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR enables guest users to visualize shipping/billing addresses on the Order Received page. For a details on why this is needed, see #43987

Closes #31990
Closes #43987

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Install and activate a non-blocks theme (eg Storefront)
  2. Without being logged in, go to a product page and add a product to the cart.
  3. Go to the checkout page.
  4. Provide both a billing and a shipping address.
  5. Place the order.
  6. See that billing and shipping address are visible on the order received page as a guest.
  7. Copy the Order Recived page link.
  8. Log in as an user, and navigate to the link saved in the previous step.
  9. Verify that billing and shipping addresses is not visible on the page
image

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Enable guest users to visualize shipping/billing information on the order received page.

Comment

@wavvves wavvves linked an issue May 14, 2024 that may be closed by this pull request
5 tasks
@wavvves wavvves self-assigned this May 14, 2024
@wavvves wavvves added type: bug The issue is a confirmed bug. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: enhancement The issue is a request for an enhancement. and removed type: bug The issue is a confirmed bug. labels May 14, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 14, 2024
@woocommercebot woocommercebot requested review from a team and senadir and removed request for a team May 14, 2024 16:01
Copy link
Contributor

github-actions bot commented May 14, 2024

Hi @senadir, @woocommerce/rubik

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented May 14, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@wavvves wavvves marked this pull request as draft May 15, 2024 08:25
@wavvves wavvves marked this pull request as ready for review May 15, 2024 08:25
@woocommercebot woocommercebot requested a review from a team May 15, 2024 08:25
Copy link
Member

@senadir senadir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out!

@senadir senadir force-pushed the fix/31990-guest-order-billing-and-shipping-address-not-visible-on-order-received-page branch from 94e596e to cc69067 Compare May 20, 2024 15:41
@wavvves wavvves added this to the 9.0.0 milestone May 20, 2024
@github-actions github-actions bot removed this from the 9.0.0 milestone May 20, 2024
@wavvves wavvves merged commit a9aa14e into trunk May 20, 2024
35 checks passed
@wavvves wavvves deleted the fix/31990-guest-order-billing-and-shipping-address-not-visible-on-order-received-page branch May 20, 2024 19:38
@github-actions github-actions bot added this to the 9.0.0 milestone May 20, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 20, 2024
@rodelgc rodelgc added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: enhancement The issue is a request for an enhancement.
Projects
None yet
3 participants