-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify components empty state #47487
Conversation
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
{ name === '' ? ( | ||
<div className="woocommerce-product-empty-state__name" /> | ||
) : ( | ||
<div>{ name }</div> | ||
) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make this more defensive, when the name
is an empty string we use a grey block.
Hi @louwie17, @woocommerce/mothra Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested well and code looks good, nice work @octaedro
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR creates an EmptyState component for multiple uses. This abstraction was meant to be used under the Variations, Attributes, and Custom Fields sections.
Closes #47293.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
/wp-admin/admin.php?page=wc-settings&tab=advanced§ion=features
.Attributes
section should show the empty stateShow custom fields toggle
.Custom fields
should be visible.Variations
tab.Changelog entry
Significance
Type
Message
Comment