Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e tests] Disable 'can remove product attributes' test #47494

Closed
wants to merge 2 commits into from

Conversation

adimoldovan
Copy link
Contributor

@adimoldovan adimoldovan commented May 15, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

products/block-editor/product-attributes-block-editor.spec.js > can remove product attributes test is too flaky an is blocking PR merges. I tried fixing it but had a hard time reproducing the failure locally. I'll disable it for now.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

CI is green. products/block-editor/product-attributes-block-editor.spec.js > can remove product attributes is skipped.

@github-actions github-actions bot added focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 15, 2024
@adimoldovan adimoldovan changed the title [e2e tests] Disable [e2e tests] Disable 'can remove product attributes' test May 15, 2024
@adimoldovan adimoldovan self-assigned this May 15, 2024
@adimoldovan adimoldovan marked this pull request as ready for review May 15, 2024 07:47
@woocommercebot woocommercebot requested a review from a team May 15, 2024 07:48
Copy link
Contributor

Hi , @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@adimoldovan adimoldovan enabled auto-merge (squash) May 15, 2024 10:13
@octaedro
Copy link
Contributor

Hi @adimoldovan,
I think that this is not necessary anymore. A fix for this test has been merged yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants