Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load locales #1362

Merged
merged 10 commits into from
Dec 29, 2022
Merged

Lazy load locales #1362

merged 10 commits into from
Dec 29, 2022

Conversation

lukashass
Copy link
Contributor

@lukashass lukashass commented Oct 28, 2022

Closes #1345

index.js size reduction: 538.71 KiB -> 382.74 KiB

Also sets correct html lang attribute.

TODO

@6543
Copy link
Member

6543 commented Nov 10, 2022

to test if key is right on linux via cli:

cat web/src/assets/locales/en.json | jq .repo.enable.success

if you get your value the key is right ;)

@6543 6543 added the ui frontend related label Nov 10, 2022
@lukashass
Copy link
Contributor Author

I couldn't get lazy loading of dayjs and TimeAgo locales to work, so I would suggest to try that later.

@lukashass lukashass marked this pull request as ready for review November 28, 2022 20:26
@anbraten anbraten added this to the 1.0.0 milestone Nov 28, 2022
@6543 6543 merged commit 72df167 into woodpecker-ci:master Dec 29, 2022
@6543
Copy link
Member

6543 commented Dec 29, 2022

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lazy load locales
4 participants