Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference: Starting item selection mode in Tracker #1320

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

jaysc
Copy link
Contributor

@jaysc jaysc commented Apr 3, 2024

Description

#1322

This is a direct copy of the starting item selection mode found in the random settings tracker.

This does not allow the user to modify starting item in launcher.

Since the logic was created for my personal tracker, some parts may be considered "hacky". As such, the methodology may not be the correct approach but may be useful in determining ways to handle this feature.

This PR is just for reference. The code has not been touched since 2023 1st half.

Usage

There's a button to toggle Starting item selection mode which allows the user to select their starting items. When in this mode, they can select what their starting item was.

When they leave the mode, the tracker reverts back to its previous state which setting their starting items and updating the logic of the tracker

Methodology

To be written up

@jaysc jaysc changed the title feat: Starting item selection mode reference: Starting item selection mode Apr 3, 2024
@jaysc jaysc changed the title reference: Starting item selection mode Reference: Starting item selection mode Apr 3, 2024
@wooferzfg
Copy link
Owner

wooferzfg commented Apr 3, 2024

I've made a ton of changes on https://github.com/wooferzfg/tww-rando-tracker/tree/next-rando-version, so any new features should go there

This is at least helpful as a reference though, thanks

@wooferzfg
Copy link
Owner

wooferzfg commented Apr 3, 2024

Also, I think this is addressing something different than what I had in mind for #1246. That was just scoped to the launcher page (the one where you choose the permalink), not the tracker

I'm assuming this one is for handling random starting items? Is the value of this just hiding those items from the requirement tooltips?

@jaysc jaysc changed the title Reference: Starting item selection mode Reference: Starting item selection mode in Tracker Apr 3, 2024
@jaysc
Copy link
Contributor Author

jaysc commented Apr 3, 2024

Also, I think this is addressing something different than what I had in mind for #1246. That was just scoped to the launcher page (the one where you choose the permalink), not the tracker

I'm assuming this one is for handling random starting items? Is the value of this just hiding those items from the requirement tooltips?

Yes this is just in the tracker window, not the launcher.

It was useful with random starting item. I'm not sure if that provides value for the next version of the randomiser. It's mainly useful to tracking spheres.

I think I might spend some time in the future add this sort of functionality to the launcher instead. I mainly made this PR as an exercise so I could look over the tracker code again since it's been a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants