Skip to content

Commit

Permalink
Remove the workaround for match mutating its parameter
Browse files Browse the repository at this point in the history
As the PR fixing the issue has now landed in fastlane 2.205.2

See fastlane/fastlane#20125
  • Loading branch information
AliSoftware committed Apr 21, 2022
1 parent 404c8cf commit 9501859
Showing 1 changed file with 1 addition and 13 deletions.
14 changes: 1 addition & 13 deletions fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -39,19 +39,7 @@ EXTENSIONS_BUNDLE_IDENTIFIERS = %w[
WordPressThisWeekWidget
WordPressIntents
].map { |suffix| "#{APP_STORE_VERSION_BUNDLE_IDENTIFIER}.#{suffix}" }
# rubocop:disable Style/MutableConstant
#
# Fastlane `match` manipulates the array of bundle identifiers it's given in a
# way that expects it to be mutable. We cannot call `.freeze`, or `match` will
# fail.
#
# See:
#
# - https://github.com/fastlane/fastlane/issues/11324
# - https://github.com/fastlane/fastlane/blob/b817148d4967ab6e38b8f1a8b81d1b3e60d6e645/match/lib/match/runner.rb#L84-L86
# - https://buildkite.com/automattic/wordpress-ios/builds/6240#ad789b9f-b744-4867-8d58-95921c58a3cf/2491-2756
ALL_BUNDLE_IDENTIFIERS = [APP_STORE_VERSION_BUNDLE_IDENTIFIER, *EXTENSIONS_BUNDLE_IDENTIFIERS]
# rubocop:enable Style/MutableConstant
ALL_BUNDLE_IDENTIFIERS = [APP_STORE_VERSION_BUNDLE_IDENTIFIER, *EXTENSIONS_BUNDLE_IDENTIFIERS].freeze
JETPACK_APP_IDENTIFIER = 'com.automattic.jetpack'

# Environment Variables — used by lanes but also potentially actions
Expand Down

0 comments on commit 9501859

Please sign in to comment.