[Tooling] Update fastlane + remove workaround for match mutation #18417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the PR fixing the issue has now landed in fastlane 2.205.2 See fastlane/fastlane#20125
AliSoftware
commented
Apr 21, 2022
Comment on lines
-50
to
-52
| # - https://github.com/fastlane/fastlane/issues/11324 | ||
| # - https://github.com/fastlane/fastlane/blob/b817148d4967ab6e38b8f1a8b81d1b3e60d6e645/match/lib/match/runner.rb#L84-L86 | ||
| # - https://buildkite.com/automattic/wordpress-ios/builds/6240#ad789b9f-b744-4867-8d58-95921c58a3cf/2491-2756 |
There was a problem hiding this comment.
Fixed by fastlane/fastlane#20125 since, which just landed in 2.205.2.
You can test the changes in Jetpack from this Pull Request by:
.ipa file can also be downloaded directly here.If you need access to App Center, please ask a maintainer to add you. |
You can test the changes in WordPress from this Pull Request by:
.ipa file can also be downloaded directly here.If you need access to App Center, please ask a maintainer to add you. |
mokagio
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
fastlaneto2.205.2matchmutating one of its parameter — as my fix for it in Fix crash in match when passing a frozen value as app_identifiers fastlane/fastlane#20125 has finally been released in2.205.2🎉To Test
bundle exec fastlane update_certs_and_profilesand verify it doesn't crash