-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of File block processor #22897
Improve performance of File block processor #22897
Conversation
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
@@ -1,7 +1,6 @@ | |||
import Foundation | |||
import Aztec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aztec was imported in this file to use HTMLProcessor
. Now the HTML processing is performed by using SwiftSoup
.
I'm moving this to the next milestone since this is not a blocker, and the code freeze will be completed today. |
👋 Hey @fluiddot, I'm bumping this PR to 24.8 since it's code freeze day. If this PR needs to target 24.7, please target the release branch once it's been cut. Thanks! |
Hi @fluiddot 👋 , I'm bumping this PR's milestone to |
Hey @fluiddot, I'm bumping the milestone for this PR to |
…essor' into update/improve-file-block-processor
8d56982
to
5612643
Compare
…ove-file-block-processor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @fluiddot! Thanks for adding the tests. 🚀
5733b49
into
update/improve-image-blocks-processor
This PR follows the same approach taken in #22896 to improve the performance of Gutenberg processors. The overall improvement will be less significant in this case (that's why the PR is marked as
Enhancement
instead ofBug
) mainly because the File block is used by fewer users than Image/Gallery blocks. Nevertheless, it will speed up the post-saving process.To test:
Follow the testing instructions to cover the functionality related to the processors for the block:
Regression Notes
Potential unintended areas of impact
The block processors are only used when saving a post. No other area should be impacted.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested saving a post with File blocks.
What automated tests I added (or what prevented me from doing so)
I added a new unit test to cover the content parsing of File blocks.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: