-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gutenberg] - Cancel failed or in progress uploads if the media block is removed #23125
Conversation
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
Definitely, restoring it to the placeholder would make sense. I'll create a ticket as a follow-up task.
That's probably the reason yes.
Oh wow, let's remove them then! I've also encountered that issue with the empty placeholder. I'll update the PR. Thank you for the feedback and testing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
… the connection availability, now that the thumbnail is updated sperately from the state and progress.
b0017cf
to
8fb6152
Compare
Related PRs:
To test follow the instructions in the Gutenberg PR's description.
Regression Notes
Potential unintended areas of impact
It should only affect the editor
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
No automated tests were added.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: