Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-App Updates: Track events #23207

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

momo-ozawa
Copy link
Contributor

@momo-ozawa momo-ozawa commented May 15, 2024

Part of https://github.com/Automattic/wordpress-mobile/issues/55
Part of https://github.com/Automattic/wordpress-mobile/issues/56

Description

  • Adds event tracking for in-app updates

How to test

Flexible update

Precondition: In Xcode, change the app version to something lower than the current app store version, e.g. 24.6

  • ✅ Verify in_app_update_shown <type: flexible> is tracked when the prompt is shown
  • ✅ Verify Tracked: in_app_update_dismissed <> is tracked when the "Cancel" is tapped
  • ✅ Verify Tracked: in_app_update_accepted <type: flexible> is tracked when the "Update" is tapped

Blocking update

Precondition: In Xcode, change the app version to something lower than the current app store version, e.g. 24.6

Precondition: Change the in app update remote config value to the current app store version

  • ✅ Verify in_app_update_shown <type: blocking> is tracked when the prompt is shown
  • ✅ Verify Tracked: in_app_update_accepted <type: blocking> is tracked when the "Update" is tapped

Todo

  • Validate / register events

Regression Notes

  1. Potential unintended areas of impact
    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 15, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23207-44887ae
Version24.8
Bundle IDorg.wordpress.alpha
Commit44887ae
App Center BuildWPiOS - One-Offs #9908
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 15, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23207-44887ae
Version24.8
Bundle IDcom.jetpack.alpha
Commit44887ae
App Center Buildjetpack-installable-builds #8956
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@momo-ozawa momo-ozawa merged commit 28de9ee into task/iau-blocking-modal May 16, 2024
24 checks passed
@momo-ozawa momo-ozawa deleted the task/iau-analytics branch May 16, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants