Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site Switcher] Pre iOS 17.0 search functionality fix. #23213

Merged
merged 2 commits into from
May 16, 2024

Conversation

alpavanoglu
Copy link
Contributor

Fixes ##23209

Description

Fixes the the new site picker's search not working issue on versions prior to iOS 17.0

Testing Steps

  1. Install & Login Jetpack App on a device that is below iOS 17.0 (15.0 to 16.*)
  2. Enable Site switcher Redesign Remote Feature Flag
  3. Navigate to site switcher from My Site
  4. ✅ Verify the search works fine.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

dangermattic commented May 15, 2024

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is assigned to the milestone 24.9 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 15, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23213-1d8ae52
Version24.9
Bundle IDcom.jetpack.alpha
Commit1d8ae52
App Center Buildjetpack-installable-builds #8963
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 15, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23213-1d8ae52
Version24.9
Bundle IDorg.wordpress.alpha
Commit1d8ae52
App Center BuildWPiOS - One-Offs #9914
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Member

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix @alpavanoglu 🏅
I confirmed that the site search works as expected on the same device I reported the issue using JP Alpha build pr23213-cbaa106 🎉

Recording
search.mov

Since my knowledge on Swift UI is practically zero I'll leave the actual code review to others 😅

Copy link
Contributor

@salimbraksa salimbraksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the bug is fixed and the code changes look good to me. 👍

@alpavanoglu alpavanoglu merged commit 34fac65 into release/24.9 May 16, 2024
24 checks passed
@alpavanoglu alpavanoglu deleted the bug/site-picker-old-version-fix-v2 branch May 16, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants