-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Site Switcher] Pre iOS 17.0 search functionality fix. #23213
Conversation
Generated by 🚫 Danger |
WordPress/Classes/ViewRelated/Blog/Site Picker/SiteSwitcherView.swift
Outdated
Show resolved
Hide resolved
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick fix @alpavanoglu 🏅
I confirmed that the site search works as expected on the same device I reported the issue using JP Alpha build pr23213-cbaa106
🎉
Recording
search.mov
Since my knowledge on Swift UI is practically zero I'll leave the actual code review to others 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm the bug is fixed and the code changes look good to me. 👍
Fixes ##23209
Description
Fixes the the new site picker's search not working issue on versions prior to iOS 17.0
Testing Steps
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: