Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Add analytics for the tags stream #23214

Merged
merged 10 commits into from
May 16, 2024
Merged

Conversation

dvdchr
Copy link
Contributor

@dvdchr dvdchr commented May 15, 2024

Part of #23069
Internal ref pctCYC-1lG-p2

This PR adds tracking for the tags stream:

  • New events
    • reader_tags_feed_shown — this is tracked upon opening the 'Your Tags' stream.
    • reader_tags_feed_more_from_tag_tapped — tracked when tapping the 'More' cell at the end of a tag post list.
    • reader_tags_feed_header_tapped — tracked when tapping the tag headers in the tags stream.
  • Added source: tags_feed parameter to
    • reader_article_liked
    • reader_article_unliked
    • reader_blog_previewed
    • reader_tag_loaded
    • reader_post_card_tapped
  • Added type: site|topic to reader_filter_sheet_cleared
  • Tracked post_card_more_tapped when the ellipsis menu of the post card is tapped in the tags stream.

To test

  • Launch the Jetpack app.
  • Go to the Reader tab, and switch to the 'Your Tags' stream.
    • 🔎 Verify 🔵 Tracked: reader_dropdown_menu_item_tapped <id: tags> appears.
    • 🔎 Verify 🔵 Tracked: reader_tags_feed_shown appears.
  • Tap one of the posts.
    • 🔎 Verify 🔵 Tracked: reader_post_card_tapped <source: tags_feed> appears.
    • Go back, and tap the site title of any post.
    • 🔎 Verify 🔵 Tracked: reader_blog_previewed <source: tags_feed> appears.
  • Go back, and like one of the posts.
    • 🔎 Verify 🔵 Tracked: reader_article_liked <source: tags_feed> appears.
  • Unlike the same post.
    • 🔎 Verify 🔵 Tracked: reader_article_unliked <source: tags_feed> appears.
  • Tap the ellipsis menu on any post.
    • 🔎 Verify 🔵 Tracked: post_card_more_tapped appears.
  • Do a smoke test by tapping one of the context menu items.
    • For example, if you tap Visit, verify that 🔵 Tracked: reader_article_visited appears.
  • Go back to the tag stream.
  • Tap one of the tag button/header.
    • 🔎 Verify 🔵 Tracked: reader_tags_feed_header_tapped appears.
    • 🔎 Verify 🔵 Tracked: reader_tag_loaded <source: tags_feed> appears.
  • Go back.
  • Scroll to the end of a post list of any tag, and tap the 'More' button.
    • 🔎 Verify 🔵 Tracked: reader_tags_feed_more_from_tag_tapped appears.
    • 🔎 Verify 🔵 Tracked: reader_tag_loaded <source: tags_feed> appears.
  • Go back.
  • Filter the stream by any tag.
  • Tap 'X' to remove the filter.
    • 🔎 Verify 🔵 Tracked: reader_filter_sheet_cleared <type: topic> appears.

Testing reader_filter_sheet_cleared in the Subscriptions stream

Regression Notes

  1. Potential unintended areas of impact
    Should be none.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested the changes.

  3. What automated tests I added (or what prevented me from doing so)
    N/A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:
N/A. Not a user-facing change.

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dvdchr dvdchr added [Type] Enhancement Reader Analytics Part of a WIP Feature This label is used to disable milestone checks for PRs that are not against `develop` or `release`. labels May 15, 2024
@dvdchr dvdchr added this to the 25.0 milestone May 15, 2024
@dvdchr dvdchr requested a review from wargcm May 15, 2024 17:26
@dvdchr dvdchr self-assigned this May 15, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 15, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23214-a7da54a
Version24.9
Bundle IDcom.jetpack.alpha
Commita7da54a
App Center Buildjetpack-installable-builds #8971
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 15, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23214-a7da54a
Version24.9
Bundle IDorg.wordpress.alpha
Commita7da54a
App Center BuildWPiOS - One-Offs #9922
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@wargcm wargcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

…iewModel.swift

Co-authored-by: Christopher McGraw <2454408+wargcm@users.noreply.github.com>
@dvdchr dvdchr enabled auto-merge May 16, 2024 17:16
@dvdchr dvdchr merged commit 60a6e15 into trunk May 16, 2024
22 of 24 checks passed
@dvdchr dvdchr deleted the issue/23069-add-analytics branch May 16, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics Part of a WIP Feature This label is used to disable milestone checks for PRs that are not against `develop` or `release`. Reader [Type] Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants