-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: Add analytics for the tags stream #23214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdchr
added
[Type] Enhancement
Reader
Analytics
Part of a WIP Feature
This label is used to disable milestone checks for PRs that are not against `develop` or `release`.
labels
May 15, 2024
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
wargcm
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
WordPress/Classes/ViewRelated/Reader/Tab Navigation/ReaderTabViewModel.swift
Outdated
Show resolved
Hide resolved
…iewModel.swift Co-authored-by: Christopher McGraw <2454408+wargcm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Analytics
Part of a WIP Feature
This label is used to disable milestone checks for PRs that are not against `develop` or `release`.
Reader
[Type] Enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #23069
Internal ref pctCYC-1lG-p2
This PR adds tracking for the tags stream:
reader_tags_feed_shown
— this is tracked upon opening the 'Your Tags' stream.reader_tags_feed_more_from_tag_tapped
— tracked when tapping the 'More' cell at the end of a tag post list.reader_tags_feed_header_tapped
— tracked when tapping the tag headers in the tags stream.source: tags_feed
parameter toreader_article_liked
reader_article_unliked
reader_blog_previewed
reader_tag_loaded
reader_post_card_tapped
type: site|topic
toreader_filter_sheet_cleared
post_card_more_tapped
when the ellipsis menu of the post card is tapped in the tags stream.To test
🔵 Tracked: reader_dropdown_menu_item_tapped <id: tags>
appears.🔵 Tracked: reader_tags_feed_shown
appears.🔵 Tracked: reader_post_card_tapped <source: tags_feed>
appears.🔵 Tracked: reader_blog_previewed <source: tags_feed>
appears.🔵 Tracked: reader_article_liked <source: tags_feed>
appears.🔵 Tracked: reader_article_unliked <source: tags_feed>
appears.🔵 Tracked: post_card_more_tapped
appears.Visit
, verify that🔵 Tracked: reader_article_visited
appears.🔵 Tracked: reader_tags_feed_header_tapped
appears.🔵 Tracked: reader_tag_loaded <source: tags_feed>
appears.🔵 Tracked: reader_tags_feed_more_from_tag_tapped
appears.🔵 Tracked: reader_tag_loaded <source: tags_feed>
appears.🔵 Tracked: reader_filter_sheet_cleared <type: topic>
appears.Testing
reader_filter_sheet_cleared
in the Subscriptions streamRegression Notes
Potential unintended areas of impact
Should be none.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested the changes.
What automated tests I added (or what prevented me from doing so)
N/A.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist:
N/A. Not a user-facing change.