Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-App Updates: Open app store listing #23216

Merged
merged 2 commits into from
May 16, 2024

Conversation

momo-ozawa
Copy link
Contributor

Part of https://github.com/Automattic/wordpress-mobile/issues/55
Part of https://github.com/Automattic/wordpress-mobile/issues/56

Description

  • Opens app store listing from "Update" CTA for flexible and blocking update views

Note

  • SKStoreProductViewController isn't a good choice for this use case, since the app will terminate during updating. Simply opening the app store listing provides a better experience.

How to test

Flexible update

Precondition: In Xcode, change the app version to something lower than the current app store version, e.g. 24.6

  • Run on a real device
  • When the flexible update is displayed, tap on "Update"
  • ✅ Verify the app store listing is displayed

Blocking update

Precondition: In Xcode, change the app version to something lower than the current app store version, e.g. 24.6

Precondition: Change the in app update remote config value to the current app store version

  • Run on a real device
  • When the blocking update is displayed, tap on "Update"
  • ✅ Verify the app store listing is displayed

Regression Notes

  1. Potential unintended areas of impact
    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23216-30d3b03
Version24.8
Bundle IDorg.wordpress.alpha
Commit30d3b03
App Center BuildWPiOS - One-Offs #9911
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23216-30d3b03
Version24.8
Bundle IDcom.jetpack.alpha
Commit30d3b03
App Center Buildjetpack-installable-builds #8960
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Base automatically changed from task/iau-analytics to task/iau-blocking-modal May 16, 2024 09:02
@momo-ozawa momo-ozawa merged commit f742dbf into task/iau-blocking-modal May 16, 2024
25 of 29 checks passed
@momo-ozawa momo-ozawa deleted the task/iau-open-app-store branch May 16, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants