Experiment with reusing the gutenberg store in the block manager #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tug
added
[Type] Enhancement
Tug
force-pushed
the
try/experiment-state
branch
2 times, most recently
from
aa80db3
to
33338ec
Compare
4 tasks
Tug
force-pushed
the
try/experiment-state
branch
7 times, most recently
from
af50202
to
c0ddc7e
Compare
Tug
force-pushed
the
try/experiment-state
branch
from
c0ddc7e
to
b178052
Compare
|
Had a sneak peak in this PR and it seems that good things are coming, thanks @Tug ! Got to say though that it will be a bit hard to review it from our small mobile side experience so far so, please make an effort to add a PR description when this is ready for review that explains what components are added, short mention of their role and use and so on. Thanks! |
|
Closing in favor of #226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we're removing the whole
storefolder and making the appropriate changes to our components for it to work with the gutenberg store. It’s probably not good to have an hybrid solution (where we use both stores).WIP
Gutenberg changes: WordPress/gutenberg#11486