Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block insertion flow e2e test #2851

Merged
merged 14 commits into from Jan 8, 2021
Merged

Add block insertion flow e2e test #2851

merged 14 commits into from Jan 8, 2021

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Nov 30, 2020 •
edited

See Gutenberg PR for more information: WordPress/gutenberg#27381

To test:

  • CI: Test iOS/Android on Device - Canaries tests should only run files with @canary in their names
  • CI: Full E2E Test suite should pass
  • Locally: npm run test:e2e:ios:local and npm run test:e2e:android:local should work as before.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

This was referenced Nov 30, 2020
Closed
Merged
@ceyhun ceyhun changed the title Add block insertion flow e2e Add block insertion flow e2e test Dec 1, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 16, 2020 •
edited

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@ceyhun ceyhun added the Testing Anything related to automated tests label Dec 17, 2020
@ceyhun ceyhun marked this pull request as ready for review December 17, 2020 12:02
@ceyhun ceyhun mentioned this pull request Dec 18, 2020
Merged
cameronvoell
cameronvoell approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#27381 (review)

I see canary tests running correctly on gb-mobile CI as well. 👍

@ceyhun ceyhun merged commit 3d3dc96 into develop Jan 8, 2021
@ceyhun ceyhun deleted the add/block-insertion-flow-e2e branch January 8, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

Assignees
No one assigned
Labels
Testing Anything related to automated tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ceyhun @cameronvoell