Update to Jest 29 #5544
Merged
Update to Jest 29 #5544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
geriux
added
Testing
geriux
commented
Mar 9, 2023
| @@ -34,7 +34,9 @@ module.exports = { | |||
| '<rootDir>/jetpack/', | |||
| '/__device-tests__/', | |||
| ], | |||
| testURL: 'http://localhost/', | |||
| testEnvironmentOptions: { | |||
There was a problem hiding this comment.
testURL is deprecated so we needed to update it to the new format.
geriux
commented
Mar 9, 2023
geriux
commented
Mar 9, 2023
geriux
commented
Mar 9, 2023
jest_setup.js
Outdated
| __esModule: true, | ||
| } ) ); | ||
|
|
||
| jest.mock( |
There was a problem hiding this comment.
After the Jest 29 update, there is an issue where it can't find the native export of this file so I added a mock.
|
FYI there are a few CI failures for this PR due to other reasons like |
geriux
commented
Mar 9, 2023
| "jest-image-snapshot": "^6.1.0", | ||
| "jest-jasmine2": "29.5.0", |
There was a problem hiding this comment.
jest-jasmine2 is no longer included with Jest and it has to be installed separately.
fluiddot
reviewed
Mar 9, 2023
jest.config.js
Outdated
| @@ -25,7 +25,7 @@ module.exports = { | |||
| // Automatically clear mock calls and instances between every test | |||
| clearMocks: true, | |||
| preset: './gutenberg/node_modules/react-native/jest-preset.js', | |||
| setupFiles: [ '<rootDir>/' + configPath + '/setup.js' ], | |||
| setupFiles: [ '<rootDir>/' + configPath + '/setup.js', './jest_setup.js' ], | |||
There was a problem hiding this comment.
Nitpick: I'm wondering if we could use a similar name format for jest_setup.js as this file, i.e. jest.setup.js, WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Jest version to
29to match Gutenberg's current version introduced in this PR.To test CI checks should pass.
PR submission checklist: