Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add
buildkite_token to buildkite_trigger_build_action in tests
The tests passed on my machine but failed in CI, see https://buildkite.com/automattic/release-toolkit/builds/1602#018f0986-a43b-49d1-884d-50c62e8af094 It turns out I had a `BUILDKITE_TOKEN` in my environment which I had forgotten about...
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,7 @@ | |
| # rubocop:enable RSpec/VerifiedDoubles | ||
|
|
||
| url = run_described_fastlane_action( | ||
| buildkite_token: 'fake-token', | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong. 
AliSoftware
Contributor
|
||
| branch: 'branch', | ||
| commit: '1a2b3c', | ||
| pipeline_file: 'pipeline.yml', | ||
|
|
@@ -43,6 +44,7 @@ | |
| expect(FastlaneCore::UI).to receive(:crash!) | ||
|
|
||
| run_described_fastlane_action( | ||
| buildkite_token: 'fake-token', | ||
| branch: 'branch', | ||
| commit: '1a2b3c', | ||
| pipeline_file: 'pipeline.yml', | ||
|
|
||
We should probably add
allow(ENV).to receive(:[]).and_return(nil)to all our tests (viatest_helper.rband/orRspec.configure?) to avoid any local ENV var of the tester's machine to impact the test, otherwise tests won't be reliable.