New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace two GitHelper methods with Fastlane actions #531
Conversation
iirc, there was a reason why we had our own I think that now that @oguzkocer implemented a workaround in fastlane in fastlane/fastlane#21597, which has been shipped in fastlane 2.217.0, this is not a problem anymore… as long as your projects have updated to this version of fastlane or later, and also that you do set If that's indeed what needs to be done to be ready to migrate, we should include a note about this in the |
@AliSoftware I updated the deprecation notice for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with wording tweak suggestions
Co-authored-by: Olivier Halligon <olivier.halligon@automattic.com>
What does it do?
This PR deprecates these two methods in the GitHelper module and replaces their uses with built-in Fastlane actions:
update_submodules
replaced bygit_submodule_update
ensure_on_branch!
replaced byensure_git_branch
I'm deprecating the methods instead of removing them because we have used some of the GitHelper methods directly instead of through Release Toolkit actions.
Checklist before requesting a review
bundle exec rubocop
to test for code style violations and recommendationsspecs/*_spec.rb
) if applicablebundle exec rspec
to run the whole test suite and ensure all your tests passCHANGELOG.md
file to describe your changes under the appropriate existing###
subsection of the existing## Trunk
section.MIGRATION.md
file to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.