Fix queue
#26
Merged
Fix queue
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine, but could use a test! Could you add one to The failure on Node 11.7 (released on 2019-01-17) is unrelated to your changes. Seems to be tracked in istanbuljs/nyc#973. I’d like to wait a bit to see if that’ll be fixed. |
This comment has been minimized.
This comment has been minimized.
|
Is writing a test for this actually necessary? Seems like a lot of work with no (or negligible) benefits. That said, here you go. |
wooorm
approved these changes
Jan 27, 2019
|
Always good to add a test! And it tracks why we deviate from original works. Released as 3.4.0, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queue is 1 syllable