Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to NPM workspaces #2919

Merged
merged 8 commits into from
Dec 28, 2022
Merged

Migrating to NPM workspaces #2919

merged 8 commits into from
Dec 28, 2022

Conversation

moufmouf
Copy link
Collaborator

This is a continuation of the package manager hell we are going through.

After failing to migrate from Yarn 1 to Yarn 2, we migrated to PNPM (#2900).

It turns out that PNPM + Docker does not work properly on MacOS, because of this open issue: pnpm/pnpm#4997

Here, I'm desperately trying to have something working everywhere. So I'm back to the old NPM (with support for workspaces though!)

@moufmouf moufmouf force-pushed the npm_migration branch 3 times, most recently from f0535a7 to e0e0a58 Compare December 27, 2022 17:16
@moufmouf moufmouf force-pushed the npm_migration branch 2 times, most recently from 17b4eb1 to ee16b38 Compare December 27, 2022 21:33
@moufmouf moufmouf changed the title [WIP] Migrating to NPM workspaces Migrating to NPM workspaces Dec 27, 2022
@moufmouf moufmouf added the deploy Create a deploy environment label Dec 28, 2022
@github-actions
Copy link

…nto npm_migration

# Conflicts:
#	pnpm-lock.yaml
@github-actions
Copy link

@moufmouf moufmouf merged commit 336948b into develop Dec 28, 2022
@moufmouf moufmouf deleted the npm_migration branch December 28, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Create a deploy environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant