-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating to NPM workspaces #2919
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moufmouf
force-pushed
the
npm_migration
branch
3 times, most recently
from
December 27, 2022 17:16
f0535a7
to
e0e0a58
Compare
moufmouf
force-pushed
the
npm_migration
branch
from
December 27, 2022 17:21
e0e0a58
to
a485147
Compare
moufmouf
force-pushed
the
npm_migration
branch
2 times, most recently
from
December 27, 2022 21:33
17b4eb1
to
ee16b38
Compare
moufmouf
force-pushed
the
npm_migration
branch
from
December 27, 2022 21:36
ee16b38
to
c2ea02f
Compare
moufmouf
changed the title
[WIP] Migrating to NPM workspaces
Migrating to NPM workspaces
Dec 27, 2022
moufmouf
force-pushed
the
npm_migration
branch
from
December 27, 2022 21:51
c082004
to
eb20052
Compare
Environment deployed at https://play-npm-migration.test.workadventu.re |
…nto npm_migration # Conflicts: # pnpm-lock.yaml
Environment deployed at https://play-npm-migration.test.workadventu.re |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the package manager hell we are going through.
After failing to migrate from Yarn 1 to Yarn 2, we migrated to PNPM (#2900).
It turns out that PNPM + Docker does not work properly on MacOS, because of this open issue: pnpm/pnpm#4997
Here, I'm desperately trying to have something working everywhere. So I'm back to the old NPM (with support for workspaces though!)