Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a standalone job for running decrypt private membership queries #1469

Open
wants to merge 1 commit into
base: stevenwarejones_debugging_write_to_kms
Choose a base branch
from

Conversation

jonmolle
Copy link
Contributor

Adds a standalone decrypt job to the panel exchange tools.

@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but I'm happy to just land this and I can take care of what I said in a follow-up

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @jonmolle)


src/main/kotlin/org/wfanet/panelmatch/client/tools/DecryptPrivateMembershipQueryResults.kt line 95 at r1 (raw file):

  @Option(
    names = ["--exchange-step-file"],

an exchange step implies an exchange-date. I'd prefer something slightly more flexible that passes in separate flags for exchangeworkflow and exchange-date and step-index and doesn't require reserialization for each day you want to run. I can do this in a follow up if you prefer since I already have this change on my branch.

Also, a nit but maybe just change the filename to BeamJobsMain.kt -- we can extend it to run any beam step.


src/main/kotlin/org/wfanet/panelmatch/client/tools/DecryptPrivateMembershipQueryResults.kt line 162 at r1 (raw file):

  private fun makePipelineOptions(): PipelineOptions {
    return PipelineOptionsFactory.`as`(BeamOptions::class.java).apply {

nit: we really shouldn't use BeamOptions here as it extends Dataflow only options, but I can take care of that in a follow-up.

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets close this one out.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @jonmolle)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants