-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherrypick: Standalone px decrypt (#1473) #1481
base: releases/v0.4.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jonmolle)
src/main/kotlin/org/wfanet/panelmatch/client/tools/BeamJobsMain.kt
line 28 at r1 (raw file):
import org.apache.beam.sdk.options.PipelineOptionsFactory import org.apache.beam.sdk.options.SdkHarnessOptions import org.wfanet.measurement.api.v2alpha.CanonicalExchangeStepAttemptKey
this didn't exist in 0.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jonmolle)
src/main/kotlin/org/wfanet/panelmatch/client/tools/BeamJobsMain.kt
line 28 at r1 (raw file):
Previously, stevenwarejones (Steven Ware Jones) wrote…
this didn't exist in 0.4
you'll need to use just ExchangeDateKey
here instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @SanjayVas)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jonmolle)
ef139a9
to
f16bff8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @SanjayVas)
src/main/kotlin/org/wfanet/panelmatch/client/tools/BeamJobsMain.kt
line 28 at r1 (raw file):
Previously, stevenwarejones (Steven Ware Jones) wrote…
you'll need to use just
ExchangeDateKey
here instead.
Yeah, exchangestepattemptkey, but same idea
Adds a tool for a standalone panel exchange private query decryption job.
3fadc14
to
e6c9296
Compare
e6c9296
to
aae60c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jonmolle)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think this is needed any more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jonmolle)
Adds a tool for a standalone panel exchange private query decryption job.