Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick: Standalone px decrypt (#1473) #1481

Open
wants to merge 2 commits into
base: releases/v0.4.x
Choose a base branch
from

Conversation

jonmolle
Copy link
Contributor

Adds a tool for a standalone panel exchange private query decryption job.

@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jonmolle)


src/main/kotlin/org/wfanet/panelmatch/client/tools/BeamJobsMain.kt line 28 at r1 (raw file):

import org.apache.beam.sdk.options.PipelineOptionsFactory
import org.apache.beam.sdk.options.SdkHarnessOptions
import org.wfanet.measurement.api.v2alpha.CanonicalExchangeStepAttemptKey

this didn't exist in 0.4

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jonmolle)


src/main/kotlin/org/wfanet/panelmatch/client/tools/BeamJobsMain.kt line 28 at r1 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

this didn't exist in 0.4

you'll need to use just ExchangeDateKey here instead.

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @SanjayVas)

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jonmolle)

Copy link
Contributor Author

@jonmolle jonmolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @SanjayVas)


src/main/kotlin/org/wfanet/panelmatch/client/tools/BeamJobsMain.kt line 28 at r1 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

you'll need to use just ExchangeDateKey here instead.

Yeah, exchangestepattemptkey, but same idea

Adds a tool for a standalone panel exchange private query decryption job.
@jonmolle jonmolle force-pushed the jmolle-v0.4.x-beam-main branch 2 times, most recently from 3fadc14 to e6c9296 Compare February 16, 2024 21:12
Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jonmolle)

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think this is needed any more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jonmolle)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants