-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix batch get metrics limit in reports service #1529
base: main
Are you sure you want to change the base?
Fix batch get metrics limit in reports service #1529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)
src/main/proto/wfa/measurement/reporting/v2alpha/metrics_service.proto
line 95 at r1 (raw file):
} ]; // A maximum of 1000 metrics can be retrieved in a batch.
I'm assuming that this limit is reasonable, i.e. all of the following are true:
- The RPC can complete in a reasonable amount of time
- A response with 1000 Metrics is unlikely to exceed the 4 MiB response size limit
- This won't cause undue pressure on machine resources
No description provided.