Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch get metrics limit in reports service #1529

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

tristanvuong2021
Copy link
Contributor

No description provided.

@wfa-reviewable
Copy link

This change is Reviewable

@tristanvuong2021 tristanvuong2021 marked this pull request as ready for review March 19, 2024 18:38
Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)


src/main/proto/wfa/measurement/reporting/v2alpha/metrics_service.proto line 95 at r1 (raw file):

    }
  ];
  // A maximum of 1000 metrics can be retrieved in a batch.

I'm assuming that this limit is reasonable, i.e. all of the following are true:

  • The RPC can complete in a reasonable amount of time
  • A response with 1000 Metrics is unlikely to exceed the 4 MiB response size limit
  • This won't cause undue pressure on machine resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants