Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reporting UI to terraform #1594

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add reporting UI to terraform #1594

wants to merge 1 commit into from

Conversation

bdomen-ggl
Copy link
Contributor

Add Reporting UI and associated services to Terraform. Also added a reporting_ui file to cmms so the Reporting UI resources are created during the GitHub action.

What is created:

  • 3 IAM service accounts (UI, GRPC, Gateway)
  • S3 bucket

@wfa-reviewable
Copy link

This change is Reviewable

@bdomen-ggl bdomen-ggl marked this pull request as ready for review April 30, 2024 17:20
@bdomen-ggl bdomen-ggl requested a review from SanjayVas May 2, 2024 12:45
Copy link
Contributor Author

@bdomen-ggl bdomen-ggl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to get Terraform working. So I may need to make some changes.

Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @SanjayVas)

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 5 files at r1, all commit messages.
Reviewable status: 3 of 5 files reviewed, 2 unresolved discussions (waiting on @bdomen-ggl)


src/main/terraform/gcloud/cmms/reporting_ui.tf line 15 at r1 (raw file):

# limitations under the License.

module "reporting_v2_cluster" {

This name is quite inaccurate, as it's definitely not a module which creates a cluster.

Code quote:

reporting_v2_cluster

src/main/terraform/gcloud/modules/reporting-ui/main.tf line 21 at r1 (raw file):

}

module "reporting_ui_user" {

This looks like the only IAM service account granted any permissions. Not every pod needs a service account; just those that need extra permissions to access things outside of the cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants