Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor InMemoryVidIndexMap out of VidIndexMap #1615

Merged
merged 5 commits into from May 10, 2024

Conversation

kungfucraig
Copy link
Member

No description provided.

@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@kungfucraig kungfucraig force-pushed the kungfucraig/packagestructure branch from 7b3f09a to d6611c9 Compare May 10, 2024 16:23
Base automatically changed from kungfucraig/packagestructure to main May 10, 2024 16:34
@kungfucraig kungfucraig force-pushed the kungfucraig/inmemoryvidindexmap branch from 2259636 to c5ad668 Compare May 10, 2024 16:40
Copy link
Member Author

@kungfucraig kungfucraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@kungfucraig kungfucraig enabled auto-merge (squash) May 10, 2024 16:42
Copy link
Member Author

@kungfucraig kungfucraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

Copy link
Member Author

@kungfucraig kungfucraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@kungfucraig kungfucraig merged commit 2e98c37 into main May 10, 2024
4 checks passed
@kungfucraig kungfucraig deleted the kungfucraig/inmemoryvidindexmap branch May 10, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants