Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spanner schema as part of K8s deployments. #561

Merged
merged 1 commit into from
May 13, 2022

Conversation

SanjayVas
Copy link
Member

@SanjayVas SanjayVas commented May 10, 2022

This also updates dev Duchy on GKE to use Workload Identity to match Kingdom.

This change is Reviewable

https://rally1.rallydev.com/#/?detail=/task/636975105303&fdp=true

@SanjayVas
Copy link
Member Author

Intended to be merged into main after base PR #546. Depends on world-federation-of-advertisers/common-jvm#109

@SanjayVas SanjayVas force-pushed the sanjayvas-liquibase-k8s branch 3 times, most recently from 8b7cffa to 895079a Compare May 11, 2022 18:42
Base automatically changed from sanjayvas-liquibase to main May 11, 2022 19:08
Copy link
Contributor

@yunyeng yunyeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we redeploy halo kingdom with these changes?

Reviewed 35 of 35 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploying this version requires a DB wipe, but after that there shouldn't be any DB wipes required.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 35 of 35 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SanjayVas)


WORKSPACE line 33 at r1 (raw file):

ADDITIONAL_MAVEN_ARTIFACTS = artifacts.dict_to_list({
    "com.google.crypto.tink:tink": "1.6.0",

why is this being removed?


src/main/k8s/local/README.md line 131 at r1 (raw file):

## Re-deploy Kingdom

Technically after the above step, you should have a fully-deployed Kingdom. If

nit: Awkward language. I would just delete the first sentence.

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)


WORKSPACE line 33 at r1 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

why is this being removed?

It's unused. Tink is pulled in from source.


src/main/k8s/local/README.md line 131 at r1 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

nit: Awkward language. I would just delete the first sentence.

The intent is to make it clear that this is just telling you how to do something, but that it's not part of the steps. How would you recommend to get that across?

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


WORKSPACE line 33 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

It's unused. Tink is pulled in from source.

can you add a TODO to pull it from maven?


src/main/k8s/local/README.md line 131 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

The intent is to make it clear that this is just telling you how to do something, but that it's not part of the steps. How would you recommend to get that across?

Congrats. You should now have a fully-deployed Kingdom. If you wish....
or
Now that you have a fully deployed kingdom, if you wish...

This also updates dev Duchy on GKE to use Workload Identity to match Kingdom.
Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)


WORKSPACE line 33 at r1 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

can you add a TODO to pull it from maven?

I'll add a TODO in world-federation-of-advertisers/common-jvm#114, as that's dealing with common Maven deps.

I believe we're still using some things from Tink that haven't made it into an official release.


src/main/k8s/local/README.md line 131 at r1 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

Congrats. You should now have a fully-deployed Kingdom. If you wish....
or
Now that you have a fully deployed kingdom, if you wish...

Done.

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas merged commit 57c5e47 into main May 13, 2022
@SanjayVas SanjayVas deleted the sanjayvas-liquibase-k8s branch May 13, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants