Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added user role location #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jydmnd
Copy link

@jydmnd jydmnd commented Sep 10, 2019

Does this close any currently open issues?
Yes, issue #58

Any other comments?
Not sure if it is the right way to implement this, but it works for my needs.

Where has this been tested?
Operating System: Mac OS X Mojave
WordPress Version: 5.2.3

@sannefoltz
Copy link

Hi, I checked your code, i think it would be very useful feature, i saw an issue in it though.

$field_groups = array_unique( array_merge( $field_groups, $field_role_groups ), SORT_REGULAR );

If the same field group is attached to multiple roles, a duplication of field names exists. (You cannot register duplicate fields on the same Type.) So this array_unique() solved it. Could this still be merged? @jydmnd @jasonbahl Thank you for all work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants