Replace DateQueryInput with strings for the dateQuery before and afte…

[kellenmace]

…r fields so that strtotime()-compatible strings can be passed in

What does this implement/fix? Explain your changes.

Replaces DateQueryInput with strings for the dateQuery before and after fields so that strtotime()-compatible strings can be passed in.

Test query:

query {
  posts(first: 10, where: {
    dateQuery: {
      after: "2020-03-13T19:05:30"
    }
  }) {
    nodes {
      title
      date
      dateGmt
    }
  }
}

Does this close any currently open issues?

Closes #1234

Any other comments?

WPGRAPHQL RULZ!

Where has this been tested?

Operating System: macOS 10.15.3
WordPress Version: 5.4

[netlify]

Deploy request for wpgraphql-docs accepted.

Accepted with commit e692197

https://app.netlify.com/sites/wpgraphql-docs/deploys/5e96105748903f00071b829c

[codecov]

Codecov Report

Merging #1239 into develop will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1239      +/-   ##
===========================================
+ Coverage    63.78%   63.79%   +0.01%     
===========================================
  Files          165      164       -1     
  Lines         9529     9510      -19     
===========================================
- Hits          6078     6067      -11     
+ Misses        3451     3443       -8     

Impacted Files	Coverage Δ
src/Registry/TypeRegistry.php	81.41% <ø> (-0.04%)	⬇️
src/Type/Input/DateQueryInput.php	51.72% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3fa876...e692197. Read the comment docs.

[jasonbahl]

@kellenmace thanks for the PR. I'll try and review shortly and provide my thoughts. 🙏

[CodeProKid]

@kellenmace I left some of my high level thoughts on here.

[CodeProKid]

I think we need tighter validation here. I think it would be better to introduce a new DateTime scalar: https://webonyx.github.io/graphql-php/type-system/scalar-types/#writing-custom-scalar-types and use that here instead.

[CodeProKid]

Since this is probably a pretty widely used input arg, I'd rather see us deprecate the existing field and introduce the new field separately. We could then make the breaking change in a future release.

[jasonbahl]

@kellenmace I've added register_graphql_scalar() as an API and I think we should probably have a maintainers meeting sooner than later to discuss what scalars might make sense to introduce and how we should introduce them. If we go the route of adding a DATETIME scalar, it would be perfect for this.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[humet]

This would be very useful for us.

[rgevrek]

This is a very useful PR, are there any plans to finish and merge? Else many inefficient calls and responses are needed on our side

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.