Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split AbstractConnectionResolver::get_args() and ::get_query_args() into ::prepare_*() methods #3124

Merged
merged 9 commits into from
May 8, 2024
Merged

refactor: split AbstractConnectionResolver::get_args() and ::get_query_args() into ::prepare_*() methods #3124

merged 9 commits into from
May 8, 2024

Commits on May 4, 2024

  1. feat: wrap AbstractConnectionResolver::is_valid_model() in `::get_i… 

    …s_valid_model()`
    @justlevine
    justlevine committed May 4, 2024
    Configuration menu
    Copy the full SHA
    cdfd1a9 View commit details
    Browse the repository at this point in the history

  2. tests: cleanup

    @justlevine
    justlevine committed May 4, 2024
    Configuration menu
    Copy the full SHA
    1d084e8 View commit details
    Browse the repository at this point in the history

  3. dev: refactor AbstractConnectionResolver::get_nodes() and `get_edge… 

    …s()` into `prepare_*()`
    @justlevine
    justlevine committed May 4, 2024
    Configuration menu
    Copy the full SHA
    b266d3e View commit details
    Browse the repository at this point in the history

  4. dev: refactor AbstractConnectionResolver::get_ids() to ::prepare_ids()

    @justlevine
    justlevine committed May 4, 2024
    Configuration menu
    Copy the full SHA
    f6babda View commit details
    Browse the repository at this point in the history

  5. dev: refactor AbstractConnectionResolver::get_args() to `::prepare_… 

    …args()`
    @justlevine
    justlevine committed May 4, 2024
    Configuration menu
    Copy the full SHA
    77d99b9 View commit details
    Browse the repository at this point in the history

  6. dev: refactor AbstractConnectionResolver::get_query_args() to `::pr… 

    …epare_query_args()`
    @justlevine
    justlevine committed May 4, 2024
    Configuration menu
    Copy the full SHA
    c62f63b View commit details
    Browse the repository at this point in the history

  7. chore: add b/c notes

    @justlevine
    justlevine committed May 4, 2024
    Configuration menu
    Copy the full SHA
    c2b3613 View commit details
    Browse the repository at this point in the history

  8. fix: use get_query_args() instead of modifying directly

    @justlevine
    justlevine committed May 4, 2024
    Configuration menu
    Copy the full SHA
    0847c89 View commit details
    Browse the repository at this point in the history

  9. ci: ignore coverage for faux abstract method

    @justlevine
    justlevine committed May 4, 2024
    Configuration menu
    Copy the full SHA
    b4aad63 View commit details
    Browse the repository at this point in the history