-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preload adaptative batch #6427
Open
MathieuLamiot
wants to merge
29
commits into
develop
Choose a base branch
from
prototype/preload-adaptative-batch
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Preload adaptative batch #6427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ious batch and errors
Conservative approach by initializing batch size to min value Check duration once per batch for the average Remove unused transient Remove transient on uninstall
…g actions as develop
…e/preload-adaptative-batch
jeawhanlee
requested changes
Feb 28, 2024
jeawhanlee
approved these changes
Feb 29, 2024
… avoid filling the AS queue at all cost.
@Khadreal Hey, I just pushed a small change to enforce the max batch size after the min batch size. This is for the case there are already 45 actions in the AS queue. In this case, no matter what, we don't want to add more to the AS queue. So the max has to be enforced after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When preparing preload batches, the batch size will be adapted based on the average duration of a request to avoid flooding servers with requests if they take too long.
To get the estimate of the request duration, we do a blocking request from time to time when triggering the preload, and measure the timing.
Fixes #6396
Type of change
Please delete options that are not relevant.
Is the solution different from the one proposed during the grooming?
Yes, on top of the original idea, we added an average mechanism that keeps track of the average request time through transients.
Checklists
Generic development checklist
Test summary
Tested locally and on the gamma website by checking transients and scheduled actions.