Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gulpfile to be more dynamic #6625

Merged
merged 9 commits into from
May 29, 2024

Conversation

wordpressfan
Copy link
Contributor

@wordpressfan wordpressfan commented May 9, 2024

Closes #6601

Here I restructured the the gulp tasks and split main tasks between css and js tasks and has a config file to define the gulp tasks and the corresponding method to do that task.

List of gulp tasks that can be called directly using gulp cli command are mentioned here:

https://github.com/wp-media/wp-rocket/blob/a8e8fead41e3103511a467bffaf634cdf3f75a9c/src/js/gulp/gulpconfig.js

Also I added main big scripts inside package.json

Q: Do we need to be backward compatible with the old gulp tasks that I removed in this PR?

…called dynamically, also added a configuration file to make it easier to see list of tasks for each module
@wordpressfan wordpressfan self-assigned this May 9, 2024
Copy link

codacy-production bot commented May 9, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 2b088a31 (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2b088a3) Report Missing Report Missing Report Missing
Head commit (a14896b) 37185 14389 38.70%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6625) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@MathieuLamiot
Copy link
Contributor

Should this PR be made a real PR and not a draft? As I see it's "Ready for review". Thanks!

@wordpressfan wordpressfan marked this pull request as ready for review May 22, 2024 09:16
@wordpressfan wordpressfan changed the title [Prototype] Refactor gulpfile to be more dynamic Refactor gulpfile to be more dynamic May 22, 2024
@Khadreal
Copy link
Contributor

gulp build:sass:all task did not complete every other tasks is fine.

cc @wordpressfan

@wordpressfan
Copy link
Contributor Author

gulp build:sass:all task did not complete every other tasks is fine.

cc @wordpressfan

Done

@Tabrisrp
Copy link
Contributor

Could you add somewhere (either in the main gulp file, or the readme) The list of all gulp commands, and what it does? That would be helpful for everyone old and new as a quick reference instead of having to inside the code.

@wordpressfan
Copy link
Contributor Author

Could you add somewhere (either in the main gulp file, or the readme) The list of all gulp commands, and what it does? That would be helpful for everyone old and new as a quick reference instead of having to inside the code.

Good idea, doing that now.

Copy link

codacy-production bot commented May 29, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 2b088a31 (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2b088a3) Report Missing Report Missing Report Missing
Head commit (51ef5a1) 37185 14389 38.70%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6625) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@wordpressfan wordpressfan added this pull request to the merge queue May 29, 2024
Merged via the queue into develop with commit 44399ce May 29, 2024
14 checks passed
@wordpressfan wordpressfan deleted the enhancement/6601-refactor-gulpfile branch May 29, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update build script to generate production scripts individually
5 participants