-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blessing/add example #40
base: main
Are you sure you want to change the base?
Conversation
@dicethedev is attempting to deploy a commit to the useWeb3 Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot that there was a useEstimateGas hook in wagmi. I'm not sure it makes sense to abstract this further into another hook. I recommend to implement a good example into the send-ether and send-token contracts. No need for this hook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that you can specify a custom list of links. But for most cases, you could construct the navigation paths from the router. Have a look at
- https://jeremykreutzbender.com/blog/app-router-dynamic-breadcrumbs
- https://medium.com/@dalibor.nerber/building-a-dynamic-breadcrumbs-component-in-next-js-2e8f40aba021
So you don't need to configure anything at all.
Ideal format: Home icon > [path name] > [:id]
If you don't mind, you should submit it as a different PR.
Use this PR for adding the gas estimation examples. And then we can work on a breadcrumb component together in a separate
Added example - Gas Estimation Tool - This example demonstrates way to estimate the gas cost of Ethereum transactions before execution.
Added a Back home button - I called the component -> BackLinkComponent -> Why this - For more better UX for users.
BackLinkComponent has been added to all example pages.