Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): allow to set the configuration path from WTF_CONFIG #1572

Merged
merged 1 commit into from
May 21, 2024

Conversation

noirbizarre
Copy link
Contributor

@noirbizarre noirbizarre commented Apr 18, 2023

Hello 👋🏼

This PR is just adding the possibility to set the configuration file path from the WTF_CONFIG environment variable (allowing use cases like by directory dashboard using direnv)

@senorprogrammer
Copy link
Collaborator

I like this, good idea.

@stale
Copy link

stale bot commented Oct 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 22, 2023
@noirbizarre
Copy link
Contributor Author

Hi 👋🏼

Is there something preventing to merge this one ?
As you seem to like this one, if there is any change or improvement needed, I would gladly make them ASAP so you can merge it

@stale stale bot removed the wontfix label Oct 23, 2023
@senorprogrammer
Copy link
Collaborator

Nope, nothing needs to be changed, life just got in the way. Apologies for the long delay.

@noirbizarre
Copy link
Contributor Author

Nope, nothing needs to be changed, life just got in the way. Apologies for the long delay.

No worries, kind of the same for me.

Anyway, I fixed the swapped statements, it should be OK

@senorprogrammer senorprogrammer merged commit fda94f2 into wtfutil:master May 21, 2024
5 checks passed
@senorprogrammer
Copy link
Collaborator

Thanks for making this improvement, this is excellent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants