Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Mode support #478

Closed
skllcrn opened this issue Jun 12, 2018 · 6 comments · Fixed by #644
Closed

Dark Mode support #478

skllcrn opened this issue Jun 12, 2018 · 6 comments · Fixed by #644
Labels
Priority: High Status: In Progress Type: Enhancement Type: Feature
Projects
3.0.0
Milestone
3.0.0

Comments

@skllcrn
Copy link
Member

skllcrn commented Jun 12, 2018

Blocked by:

electron/electron#12726
electron/electron#13175
https://www.chromestatus.com/feature/5679432723333120
@sindresorhus
Copy link
Member

chromestatus.com/feature/5679432723333120

You can actually use this today: https://github.com/lukechilds/hyperdex/blob/1b3587a094d332a0f59d46824fe52cb554a0e9ba/app/index.js#L90

@skllcrn
Copy link
Member Author

skllcrn commented Sep 1, 2018

Apple have released design resources for macOS: Introducing Apple Design Resources for macOS

There's also a bunch of great videos from WWDC, check out "Introducing Dark Mode"!

@skllcrn skllcrn added this to the 3.0.0 milestone Sep 21, 2018
@skllcrn skllcrn added this to To do in 3.0.0 Sep 21, 2018
@skllcrn
Copy link
Member Author

skllcrn commented Sep 24, 2018

Latest progress electron/electron#14755

@sergeysova
Copy link

electron/electron#13387

@skllcrn skllcrn mentioned this issue Sep 27, 2018
Closed
@sindresorhus sindresorhus mentioned this issue Oct 4, 2018
Merged
@skllcrn
Copy link
Member Author

skllcrn commented Oct 4, 2018 •
edited

Support for Mojave native components #567

@sindresorhus
Copy link
Member

I've added an API to electron-util that makes it super simple to handle Dark Mode: https://github.com/sindresorhus/electron-util#darkmode

@skllcrn skllcrn moved this from To do to In progress in 3.0.0 Jan 31, 2019
@karaggeorge karaggeorge mentioned this issue Mar 10, 2019
Merged
3.0.0 automation moved this from In progress to Production ready Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: High Status: In Progress Type: Enhancement Type: Feature
Projects
No open projects
3.0.0
  
Production ready
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Dark Mode 🎉 wulkano/Kap
4 participants
@sindresorhus @albinekb @sergeysova @skllcrn