-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Preferences and add tab support #643
Conversation
In Plugins => Discover, if I tab until the last plugin in the list, and then tab again, it seems to select something hidden. If I tab yet another time, it selects the "General" tab. |
Otherwise, looks good. |
This needs some design tweaks, but we can address that in #644. |
@sindresorhus Yeah, that happens in all windows. I noticed it first when I was working on the cropper and it drove me crazy. The element that receives focus after the last one is the |
@karaggeorge Ah ok. Can you open an issue so we can track it? Maybe some random person passing by have a good workaround. Would be good to include a link to the Chrome issue too. |
Updates the tab display on the Preferences window and adds tab support.
Also adds tab support to the plugin config window.
Finally, it attempts to fix this bug. Haven't been able to reproduce in this branch's build yet. I think it had something to do with the
Item
components not being the same when the page was server-rendered and when it was being rendered on the app. I gave the components a key so hopefully that fixed it