Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for websocket subprotocol #776

Merged
merged 26 commits into from
May 21, 2024
Merged

feat: add support for websocket subprotocol #776

merged 26 commits into from
May 21, 2024

Conversation

JivusAyrus
Copy link
Member

@JivusAyrus JivusAyrus commented May 9, 2024 •
edited by devsergiy

fixes ENG-5142 - add websocket-subprotocol config feature
fixes ENG-5180 - fix abstract selection rewrites for __typename and interface fragments not present in the current subgraph
fixes ENG-5181 - fix requires directive regression - query fields mentioned in the requires
directives were leading to not passing those fields via representations

TODO

jensneuse
jensneuse requested changes May 13, 2024
View reviewed changes
cli/src/commands/graph/monograph/commands/create.ts Outdated Show resolved Hide resolved
cli/src/commands/graph/monograph/commands/create.ts Outdated Show resolved Hide resolved
cli/src/commands/graph/monograph/commands/update.ts Outdated Show resolved Hide resolved
cli/src/commands/graph/monograph/commands/update.ts Outdated Show resolved Hide resolved
cli/src/commands/subgraph/commands/create.ts Outdated Show resolved Hide resolved
cli/src/commands/subgraph/commands/publish.ts Outdated Show resolved Hide resolved
cli/src/commands/subgraph/commands/publish.ts Outdated Show resolved Hide resolved
cli/src/commands/subgraph/commands/update.ts Outdated Show resolved Hide resolved
controlplane/migrations/0087_deep_lake.sql Outdated Show resolved Hide resolved
controlplane/src/core/repositories/SubgraphRepository.ts Show resolved Hide resolved
StarpTech
StarpTech requested changes May 17, 2024
View reviewed changes
cli/src/commands/graph/monograph/commands/create.ts Outdated Show resolved Hide resolved
router/pkg/config/config.schema.json Outdated Show resolved Hide resolved
cli/src/commands/subgraph/commands/update.ts Outdated Show resolved Hide resolved
router/core/factoryresolver.go Outdated Show resolved Hide resolved
router/core/factoryresolver.go Show resolved Hide resolved
@StarpTech
Copy link
Contributor

Please also don't forget to update and extends the docs.

StarpTech
StarpTech approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JivusAyrus JivusAyrus merged commit e35aa26 into main May 21, 2024
19 checks passed
StarpTech added a commit that referenced this pull request May 21, 2024
@StarpTech
Revert "feat: add support for websocket subprotocol (#776)"
c07373c 
This reverts commit e35aa26.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarpTech StarpTech StarpTech approved these changes

@jensneuse jensneuse jensneuse approved these changes

Assignees
No one assigned
Labels
aws-lambda-router cli connect controlplane graphqlmetrics protocol router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JivusAyrus @StarpTech @jensneuse