feat: implement subscription filter #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-to-edfs # Conflicts: # pnpm-lock.yaml # router-tests/testenv/testenv.go # router/core/executor.go
…-to-edfs # Conflicts: # router/core/executor.go # router/gen/proto/wg/cosmo/node/v1/node.pb.go
…-to-edfs # Conflicts: # aws-lambda-router/go.sum # composition-go/index.global.js # router-tests/go.mod # router-tests/go.sum
…-to-edfs # Conflicts: # composition-go/index.global.js
github-actions
bot
added
monorepo
controlplane
protocol
connect
router
graphqlmetrics
labels
StarpTech
requested changes
May 16, 2024
jensneuse
approved these changes
May 17, 2024
There was a problem hiding this comment.
I think you've implemented unnecessarily overlapping tests.
The filter is transport agnostic as it's implemented in the engine.
If we change something in the future, we'd have to change all tests for all transports, but we're not getting any additional value from these overlapping tests.
If I'm not missing something, I'd prefer to have as few tests as possible and as many as they are adding additional test coverage, which is not the case here.
That said, looks very good!
…tion-filter # Conflicts: # aws-lambda-router/go.mod # aws-lambda-router/go.sum # composition-go/index.global.js # demo/go.mod # demo/go.sum # router-tests/go.mod # router-tests/go.sum # router-tests/kafka_events_test.go # router-tests/nats_events_test.go # router/gen/proto/wg/cosmo/node/v1/node.pb.go # router/go.mod # router/go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
TODO