New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add transformation option to the field configuration #474
Open
bakjos
wants to merge
1
commit into
wundergraph:master
Choose a base branch
from
bakjos:bakjos/field_transformations
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakjos
commented
Dec 23, 2022
pkg/engine/plan/plan.go
Outdated
@@ -933,6 +1008,25 @@ func (v *Visitor) resolveFieldPath(ref int) []string { | |||
return []string{fieldName} | |||
} | |||
|
|||
func (v *Visitor) resolveTransformation(ref int) *pipe.Pipeline { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put it as an independent function, but for performance could be done as part of the resolveFieldPath
function
bakjos
force-pushed
the
bakjos/field_transformations
branch
2 times, most recently
from
January 6, 2023 18:15
b0e92de
to
fbeebed
Compare
bakjos
force-pushed
the
bakjos/field_transformations
branch
2 times, most recently
from
January 27, 2023 21:54
b891bb1
to
6b78285
Compare
bakjos
force-pushed
the
bakjos/field_transformations
branch
from
February 16, 2023 18:18
98ae18e
to
e146e43
Compare
bakjos
force-pushed
the
bakjos/field_transformations
branch
from
February 28, 2023 21:02
e146e43
to
7e953c6
Compare
bakjos
force-pushed
the
bakjos/field_transformations
branch
from
March 29, 2023 14:16
7e953c6
to
452447c
Compare
bakjos
force-pushed
the
bakjos/field_transformations
branch
from
April 18, 2023 09:48
452447c
to
fb05844
Compare
bakjos
force-pushed
the
bakjos/field_transformations
branch
from
May 8, 2023 14:20
fb05844
to
7a46c29
Compare
bakjos
force-pushed
the
bakjos/field_transformations
branch
from
May 31, 2023 00:07
7a46c29
to
7c70039
Compare
bakjos
force-pushed
the
bakjos/field_transformations
branch
2 times, most recently
from
July 2, 2023 13:25
5c9b340
to
ace1e3e
Compare
bakjos
force-pushed
the
bakjos/field_transformations
branch
from
July 18, 2023 13:27
ace1e3e
to
3dfd50c
Compare
bakjos
force-pushed
the
bakjos/field_transformations
branch
2 times, most recently
from
August 1, 2023 23:25
cc544c9
to
c02090c
Compare
bakjos
force-pushed
the
bakjos/field_transformations
branch
2 times, most recently
from
August 14, 2023 20:50
e124c3d
to
18a35cd
Compare
bakjos
force-pushed
the
bakjos/field_transformations
branch
from
August 28, 2023 19:38
18a35cd
to
e0170ca
Compare
Hi @bakjos v1 is no longer under active development what should we do with this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option for applying a transformation using the pipeline library to fix #473