New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: svelte query client (#683)Co-authored-by: Sergiy Petrunin <spetrunin@users.noreply.github.com> Co-authored-by: Eelco Wiersma <contact@pagebakers.nl> Co-authored-by: Pagebakers <eelco@appulse.nl> #683
feat: svelte query client (#683)Co-authored-by: Sergiy Petrunin <spetrunin@users.noreply.github.com> Co-authored-by: Eelco Wiersma <contact@pagebakers.nl> Co-authored-by: Pagebakers <eelco@appulse.nl> #683
Conversation
@DaniAkash is attempting to deploy a commit to the WunderGraph Team on Vercel. A member of the Team first needs to authorize it. |
Great work! is there anything you need help with? |
The subscription test cases are failing. Might need some help with it. |
Since I'm new to svelte, I might have made some mistakes in the readable store implementation. Will try to figure out the issue |
Thanks, I will try it out once I have the time. |
It is fixed now. All tests are passing 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great overall! Left some comments for improvements.
Will you also add a svelte/sveltekit example?
@Pagebakers would like your review on the |
Code looks good, but I'm unable to run the tests locally. (with CI it's expected not to work)
|
This PR is a draft of my initial implementation of Wundergraph Client for sveltekit, created to collect feedback from the maintainers of this project. There's still few pending items I need to address before this PR can be ready:
Checklist
make test