Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bluray][simple menu] Search for a user provided list of playlists. #12537

Merged
merged 1 commit into from
Jul 22, 2017
Merged

[bluray][simple menu] Search for a user provided list of playlists. #12537

merged 1 commit into from
Jul 22, 2017

Conversation

ace20022
Copy link
Member

No description provided.

@ace20022 ace20022 added Type: Improvement non-breaking change which improves existing functionality v18 Leia labels Jul 20, 2017
@ace20022 ace20022 added this to the L 18.0-alpha1 milestone Jul 20, 2017
Rechi
Rechi reviewed Jul 20, 2017
View reviewed changes
Copy link
Member

@Rechi Rechi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regex handling looks correct
just a note: leading zeros are also counted for digit length

xbmc/filesystem/BlurayDirectory.cpp
}

uint8_t maxLines = 100;
while ((maxLines > 0) && file.ReadString(buffer, 1024))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

xbmc/filesystem/BlurayDirectory.cpp
maxLines--;
if (StringUtils::StartsWithNoCase(buffer, "playlists"))
{
int pos = 0;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

xbmc/filesystem/BlurayDirectory.cpp Outdated
if (StringUtils::StartsWithNoCase(buffer, "playlists"))
{
int pos = 0;
while ((pos = pl.RegFind(buffer, static_cast<uint32_t>(pos))) >= 0)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@ace20022
Copy link
Member Author

@koying stoi doesn't work for android currently. Do you know of a simple alternative/solution?

@koying
Copy link
Contributor

koying commented Jul 21, 2017

Just not in the NDK, yet: android/ndk#82
Good ol' strtolis your friend, I guess

@ace20022
Copy link
Member Author

Yes, that worked. Thx both of you

@ace20022
[bluray][simple menu] Search for a user provided list of playlists.
1d1ca0c 
This list has be be given in a file named disc.inf located at the root folder of the disc.
The list has to be given in a line starting with "playlists", e.g., "playlists=1, 20, 300".
@ace20022 ace20022 merged commit 12dc781 into xbmc:master Jul 22, 2017
@ace20022 ace20022 deleted the bd_PlInfo branch July 22, 2017 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rechi Rechi Rechi left review comments

Assignees
No one assigned
Labels
Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ace20022 @koying @Rechi