-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Video] Fix for videoversions (and other fixes) and bluray:// paths (fix 2 for #24720). #25140
base: master
Are you sure you want to change the base?
Conversation
@CrystalP - grateful for your thoughts, thanks. |
I've played around with versions and extras and can't find a difference between v21. I do note a couple of ? bugs that are also present in v21
|
Thanks for working on a followup.
|
OK, fixed the first two. |
766cdad
to
f5333ec
Compare
You may have pushed the wrong commits, I don't see how the first two points are addressed. |
Sorry. I fixed it and then tested it and it didn't work. Regarding the first point. The new fileId can get generated in multiple places - (eg.update last played, streamdetails etc..) so it's not really possible to bring it into SaveFileStateJob. The FileId routines are not being called every time, only if the streamdetails have changed. I have addressed the second point - I've reverted SetStreamDetails back to a void function. That's how it is in v21. |
@CrystalP, was this OK?? |
c606034
to
807b160
Compare
Description
Following on from discussion in #24720.
Fixes:
files
andpath
entriesChanges:
movies
table at c22 andepisodes
table at c18 (for movies this base path can be used to look for external subtitles and audio).path
table is not changed (other than to remove any orphan entries)files
table (hence changes toSplitPath()
andConstructPath()
)Motivation and context
How has this been tested?
What is the effect on users?
Screenshots (if appropriate):
Types of change
Checklist: