Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] do not use distutils in cmake scripts #25211

Merged
merged 1 commit into from
May 18, 2024

Conversation

hbiyik
Copy link

@hbiyik hbiyik commented May 14, 2024

Distutils is removed since python3.12

Description

Instead use sysconfig which is available since python3.2.

Motivation and context

If not using a linux system with python 3.12 will cause installing eventclient python libs to / root folder since PYTHON_LIB_PATH is not resolved

How has this been tested?

tested on archlinux

What is the effect on users?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

Distutils is removed since python3.12
@neo1973 neo1973 added Type: Fix non-breaking change which fixes an issue CMake Backport: Needed v22 "P" labels May 14, 2024
@neo1973 neo1973 added this to the "P" 22.0 Alpha 1 milestone May 14, 2024
@hbiyik
Copy link
Author

hbiyik commented May 14, 2024

i also have a nexus port if needed for an extra pr.

@fuzzard
Copy link
Contributor

fuzzard commented May 14, 2024

Nexus isn't opened for any more merges

@fuzzard fuzzard merged commit ca8f70a into xbmc:master May 18, 2024
2 checks passed
@fuzzard
Copy link
Contributor

fuzzard commented May 18, 2024

Cheers for the PR. Feel free to open a backport PR for Omega branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants