Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Fix network link status in system info #25215

Merged
merged 1 commit into from
May 16, 2024

Conversation

joseluismarti
Copy link
Contributor

Description

The NETWORK_LINK_STATE label is missing.

It was mistakenly removed when move network infos to sysinfo (d264316)

How has this been tested?

Now shows "Link: Connected"

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@howie-f howie-f added Type: Fix non-breaking change which fixes an issue v22 "P" labels May 15, 2024
@howie-f howie-f added this to the "P" 22.0 Alpha 1 milestone May 15, 2024
@jenkins4kodi jenkins4kodi merged commit 4bf07f0 into xbmc:master May 16, 2024
1 of 2 checks passed
@joseluismarti joseluismarti deleted the network_link_state branch May 17, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport: Done Type: Fix non-breaking change which fixes an issue v22 "P"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants