Add verification of components in Xcode.app #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Verify authority of first signing chain * Verify team identifier
kenchan0130
force-pushed
the
verify_xcode_components
branch
from
78356a2
to
b579212
Compare
|
I want to merge if there is no opinion 👀 |
kenchan0130
commented
Dec 26, 2018
| result = `pkgutil --verbose --check-signature #{pkg} | grep 'Status'` | ||
| result.strip.split(':')[1].strip == "signed #{COMPONENT_SIGNING_COMMON_NAME}" | ||
| end | ||
| result.all? |
There was a problem hiding this comment.
I have thought that you can verify comprehensively by checking root ca.
I'll try to change this logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can see accurate diff on kenchan0130/xcode-install@hard_verify_xcode...verify_xcode_components because this patch is done checkout from #312.
related #298