Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental support for Windows Named Pipes control socket #955

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zobo
Copy link
Contributor

@zobo zobo commented Mar 14, 2024

No description provided.

Copy link
Contributor

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am generally OK with this idea, but I think I would like to see the following changes:

  1. define a new HAVE_CTRL_SOCKET_SUPPORT flag, either in the config.m4/config.w32 script, or otherwise in php_xdebug.h — this prevents the #ifdef __linux__ | WIN32 shenanigans (which is not really descriptive)
  2. I think the Windows specific code should not be in ctrl_socket.c, but rather in ctrl_socket_named_pipes.c (and extracting the specific Unix socket code from ctrl_socket.c into a new ctrl_socket_unix_socket.c file). handle_command and the CTRL_FUNC(…) functions can remain. The other common interfaces can be called from the functions already existing in ctrl_socket.c (i.e., xdebug_control_socket_setup calls xdebug_control_socket_named_pipes_setup and xdebug_control_socket_unix_sockets_setup), etc.
  3. How do we do tests? I don't know, but I would like to have some. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants